Repository navigation
Pin the coverage gate to rustc 1.99.1 and cover the files it flagged - #174
Merged
M3gA-Mind merged 3 commits intoNov 12, 2026
Merged
Conversation
The per-file gate's line accounting depends on the compiler: under 1.100.0 the same tests over the same code count different lines as coverable and as covered, which turned main's coverage job red when the runner's stable moved. The gate now installs and uses one pinned toolchain, bumped on purpose together with whatever the new numbers need.
The last conflicting attempt already returned its own error, so the "retry budget exhausted" error after the loop could never be reached. Fold the budget into the conflict arm's guard and drop the dead tail. Cover the debug form, a failed write, and an exhausted budget directly.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Tiny Sweeper reviewReviewed head: Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): Pin the coverage gate to rustc 1.99.1 and cover the files it flagged. Tiny Sweeper completed its review; deterministic results follow. Review snapshot
Completeness: Complete Features
Tests
FindingsNo active actionable findings. Before mergeNone. How this fits togetherflowchart LR
n0["..._port_failures_keep_the_operation_context<br/>changed"]:::changed
n1["...me_cannot_redirect_a_staged_write_outside<br/>changed"]:::changed
n2["validate_id<br/>changed"]:::changed
n3["...exec_is_admitted_through_the_module_guard<br/>changed"]:::changed
n4["clone"]:::impacted
n5["storage"]:::impacted
n6["...annot_publish_unacknowledged_staged_bytes"]:::impacted
n7["failure"]:::impacted
n8["io"]:::impacted
n9["..._bounded_binary_ranges_from_the_workspace"]:::impacted
n0 -->|calls| n4
n0 -->|tests| n4
n0 -->|calls| n5
n0 -->|tests| n5
n1 -->|calls| n4
n1 -->|tests| n4
n1 -->|calls| n8
n1 -->|uses| n8
n1 -->|tests| n8
n2 -->|calls| n7
n3 -->|calls| n4
n3 -->|tests| n4
n6 -->|calls| n4
n6 -->|tests| n4
n6 -->|calls| n8
n6 -->|tests| n8
n9 -->|calls| n8
n9 -->|tests| n8
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The coverage job on main has failed since GitHub's
stabletoolchain moved from rustc 1.99.1 to 1.100.0. The code and tests didn't change, but the per-file line counts did.grants/floor.rsgoes from 97 lines to 88, andblocking.rsfrom 74 to 69.The gate's line accounting depends on the compiler, so this PR pins the gate to one toolchain and raises the seven files with tests.
scripts/check-coverage.shinstalls rustc 1.99.1 withllvm-toolsand runs the gate withRUSTUP_TOOLCHAIN=1.99.1. The pin covers only the coverage gate. The other jobs keep tracking stable, and norust-toolchain.tomlis added. A comment explains that the pin is bumped on purpose, together with whatever the new numbers need.Repo::updatehad an unreachable tail. The last conflicting attempt already returned its own error, so the "retry budget exhausted" error after the loop could never be produced. The budget now sits in the conflict arm's guard, and the dead tail is gone.Related issue
None. The coverage job is red on main and blocks #141.
API or behavior changes
None.
Repo::updatereturns exactly what it returned before: the last attempt's conflict once the budget is spent.Validation
Run on our Linux CI runner at b315b64, against main f923a4a, with rustc 1.99.1:
cargo fmt --all -- --check: clean.cargo clippy --all-targets --all-features -- -D warnings: 0 errors.cargo build --all-targets --all-features --locked, andRUSTDOCFLAGS="-D warnings" cargo doc --no-deps --all-features: ok.bash scripts/check-coverage.shtwice, each from a clean build: 1677 passed, 0 failed and 4 ignored in each run, with nothing skipped. The per-file numbers are identical across the two runs. The only file below 90% is the one explained below.The runner has no
pasta, socrates/tinybox-jail/src/bwrap/pasta.rsis below 90% there, on main as well (118/154). On GitHub's runner it is at 97%.Per-file line coverage for the seven files, main vs this branch (covered/coverable), from both runs:
crates/tinybox-drivers/src/blocking.rscrates/tinybox-drivers/src/index_store.rscrates/tinybox-drivers/src/repo.rscrates/tinybox-drivers/src/template_store.rscrates/tinybox-host/src/files.rscrates/tinybox-module/src/tinybus_module/resources.rscrates/tinybox-sync/src/fingerprint/walk.rsFor reference, main under 1.100.0 on GitHub: blocking.rs 86.96%, index_store.rs 86.67%, repo.rs 89.92%, template_store.rs 89.72%, files.rs 89.84%, resources.rs 89.08%, walk.rs 88.64%.
Tests
tinybox-driversrepo::tests(new file):tinybox-driverstemplate_store::tests: an import reports a failed insert, and it reports a conflict whose row has disappeared.tinybox-hostfiles::tests:tinybox-moduleresources::mapping_tests(new file):tinybox-moduleresources::tests:blocking.rs,index_store.rsandwalk.rsmisses are already hit in the merged per-line view. The summary still counts them against a second compiled copy of the crate, the library that other crates' tests link, where they never run..map_errclosures for read, seek and file-type failures can't be made to fail deterministically.Documentation
scripts/check-coverage.sh: why the gate is pinned and how the pin is bumped.Checklist
#[allow(...)],#[ignore], or relaxed lints.envcontents in the diff or the description